fix(security): pin snakeyaml to 2.2 (CVE-2022-1471)#165
Open
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Open
fix(security): pin snakeyaml to 2.2 (CVE-2022-1471)#165devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
devin-ai-integration[bot] wants to merge 1 commit intoDevOpsfrom
Conversation
Co-Authored-By: Achal Channarasappa <achal.channarasappa@cognition.ai>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remediates CVE-2022-1471 (Critical) — SnakeYAML ≤ 1.33 allows arbitrary class instantiation via the default
Constructor, enabling deserialization RCE whennew Yaml()is used on untrusted input.Fix: Add a
<dependencyManagement>entry to the rootpom.xmlpinningorg.yaml:snakeyamlto2.2. In 2.x the safe constructor is the default, so forcing the transitive version pulled by Spring Boot to 2.2 mitigates the vulnerability.Code scan:
grep -rn 'org.yaml.snakeyaml' src/returned no matches — the app does not directly constructnew Yaml(), so the version pin alone is sufficient (noSafeConstructorswap needed).Dependency-tree verification
Review & Testing Checklist for Human
DevOps(the repo's default branch). The parent task spec requestedmain, but nomainbranch exists on this repo — please confirmDevOpsis the intended target, or re-target if amainbranch should be created.mvn -DskipTests -B dependency:tree -Dincludes=org.yaml:snakeyamllocally to reproduce the resolution.Notes
pom.xmlper finding; no changes to Jackson, Spring Boot parent, or JWT config (handled by sibling sessions).Link to Devin session: https://app.devin.ai/sessions/14a13554816f40e5a87ae530a1149df8
Requested by: @achalc